inspector: restore 9229 as a default port #8550
Conversation
nodejs-github-bot
added
the
c++
Some tools are now relying on 9229 to be node.js "inspector" port (I see Chrome extensions, some online blog posts, etc.) Also, having same default port values for old and new protocols may lead to some confusion, e.g. when tools are trying to autodiscover debuggable Node instances.
eugeneo
changed the title
|
I've updated the commit message. |
|
Failure seems to be coming from "git gc" command execution. |
|
Is there a reason you didn't simply revert 9f1f7e2? If yes, can you at least mention in the commit log that you are rolling back that commit? |
|
Sorry, I'm going to opt out of signing off on this as I don't agree with the change. |
|
@cjihrig: can you elaborate on your concerns? I think debuggers have a valid use-case to require different protocols to run on different ports when trying to attach to existing node processes, or to auto-discover debuggable node processes. |
|
@ofrobots I didn't realize that this would preserve the fix for #8201 (TBH, I hadn't reviewed these changes at that point, assuming it was essentially a revert). That makes me OK with it. That said, I'm still worried if debuggers are relying on the port number to determine which protocol is used, as there is nothing stopping users from changing the port. I understand the auto-discovery point, as I'm one of the authors of the aforementioned Chrome extensions. |
|
/cc @roblourens @nodejs/diagnostics |
Can you review and sign-off? |
|
Thanks! Landed as 626a07d. |
Some tools are now relying on 9229 to be node.js "inspector" port (I see Chrome extensions, some online blog posts, etc.) Also, having same default port values for old and new protocols may lead to some confusion, e.g. when tools are trying to autodiscover debuggable Node instances. This is a partial revert of 9f1f7e2. This commit preserves the fix for issue #8201 bringing back the behavior that the old and new protocols run on different ports.run on different ports. PR-URL: #8550 Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
This commit adds a test for the debug port value in cluster workers using the inspector debugger. Refs: nodejs#8201 Refs: nodejs#8386 Refs: nodejs#8550 PR-URL: nodejs#8958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
This commit adds a test for the debug port value in cluster workers using the inspector debugger. Refs: #8201 Refs: #8386 Refs: #8550 PR-URL: #8958 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Some tools are now relying on 9229 to be node.js "inspector" port (I see
Chrome extensions, some online blog posts, etc.) Also, having same
default port values for old and new protocols may lead to some
confusion, e.g. when tools are trying to autodiscover debuggable Node
instances.
CC: @ofrobots, @cjihrig, @bnoordhuis