Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickprocessor: pass proper arguments to /bin/sh #8480

Closed
wants to merge 1 commit into from

Commits on Sep 10, 2016

  1. tickprocessor: apply c++filt manually on mac

    `/bin/sh -c` trick wasn't working for several reasons:
    
    * `/bin/sh -c "..."` expects the first argument after `"..."` to be a
      `$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
      this, and many symbols were ordered improperly
    * `c++filt` was applied not only to the names of the functions but to
      their `nm` prefixes like `t` and `a` (`t xxx` turns into
      `unsigned char xxx`).
    
    Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
    requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
    matching entries manually.
    
    Included test demonstrates where previous approach failed: all builtins
    were merged into `v8::internal::Builtins::~Builtins`, because they were
    prefixed by `t` in `nm` output.
    indutny committed Sep 10, 2016
    Configuration menu
    Copy the full SHA
    97bd7cd View commit details
    Browse the repository at this point in the history