Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip pseudo-tty/no_dropped_stdio test #8470

Closed
wants to merge 1 commit into from
Closed

test: skip pseudo-tty/no_dropped_stdio test #8470

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Sep 9, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

We had marked pseudo-tty/no_dropped_stdio as flaky but
in some failures it hangs and does not seem to timeout,
and or is reported as an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawson mhdawson removed the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
f44c13f 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
@mhdawson mhdawson self-assigned this Sep 9, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Sep 9, 2016

CI run: https://ci.nodejs.org/job/node-test-pull-request/3990/

@mhdawson mhdawson added the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Sep 9, 2016

CI run was all green.

@santigimeno
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Sep 10, 2016

LGTM

mhdawson added a commit that referenced this pull request Sep 12, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
1ffdbb6 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@mhdawson
Copy link
Member Author

Landed as 1ffdbb6

@mhdawson mhdawson closed this Sep 12, 2016
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
@mhdawson @Fishrock123
test: skip pseudo-tty/no_dropped_stdio test
3294c2c 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
fc9f46b 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@mhdawson mhdawson mentioned this pull request Oct 3, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
2c31e5b 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@mhdawson @rvagg
test: skip pseudo-tty/no_dropped_stdio test
a3eb9b8 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@mhdawson @MylesBorins
test: skip pseudo-tty/no_dropped_stdio test
ad1230e 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@mhdawson mhdawson deleted the pseudo branch March 15, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhdawson mhdawson

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhdawson @santigimeno @jasnell @MylesBorins @nodejs-github-bot