test: fix test-cluster-dgram-1 flakiness #8383
Conversation
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: nodejs#8380
santigimeno
added
cluster
|
LGTM |
|
Test results on AIX For the original before the refactor I got 0 failures out of 200 runs. After the refactor I get 46/150 failures With this fix the frequency of failures goes done to about 3/150 but it still fails consistently with: (note it says parallel/test-cluster-dgram-3 as opposed to parallel/test-cluster-dgram-1 simply because I copied the new version into a different file for testing). Mismatched function calls. Expected 10, actual 0. So the next is that it makes things better but does not completely resolve the flakiness at least on AIX. |
|
@mhdawson I have pushed a fix. Can you try again? Thanks! |
|
@santigimeno that seems to do the trick 0 failures out of 450 so LGTM. |
|
FWIW, given how this is being fixed, I could be wrong but it looks like the refactor didn't actually break the test as much as highlight a failure that had already been happening but hadn't been caught. |
|
LGTM |
|
I'd say given the breakage that the changes in the test are causing in CI, if this is non-controversial we shouldn't need to wait the 48 hours to land. /cc @Trott |
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: #8380 PR-URL: #8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
|
Agreed on the "landing sooner than 48 hours" suggestion. |
|
landed as 2d2a2d7 |
|
I understand the hurry, but I was counting on amending the commit message before merging because, after the fixup commit, the fix explanation was different. |
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: nodejs#8380 PR-URL: nodejs#8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: #8380 PR-URL: #8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: nodejs#8380 Ref: nodejs#8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
|
@thealphanerd backport to 4.x here: #9109 |
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: #8380 Ref: #8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: #8380 Ref: #8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Check for the number of messages received in the
exitevent listenerinstead of the
disconnectlistener.Fixes: #8380