Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test sending over a closed IPC channel #8160

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 18, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This commit adds a test that attempts to send data over an IPC channel once it has been closed.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 18, 2016
@cjihrig cjihrig added the child_process Issues and PRs related to the child_process subsystem. label Aug 18, 2016
@Trott
Copy link
Member

Trott commented Aug 18, 2016

LGTM if CI is green

@santigimeno
Copy link
Member

@claudiorodriguez
Copy link
Contributor

LGTM

This commit adds a test that attempts to send data over an IPC
channel once it has been closed.

PR-URL: nodejs#8160
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
@cjihrig cjihrig merged commit 7b1b0c4 into nodejs:master Aug 20, 2016
@cjihrig cjihrig deleted the test2 branch August 20, 2016 20:21
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
This commit adds a test that attempts to send data over an IPC
channel once it has been closed.

PR-URL: #8160
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
@MylesBorins
Copy link
Contributor

This test is failing when backported to v4.x

Adding don't land label. Feel free to let me know if something needs to be backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants