doc: update build instructions for Windows #7285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions.
joaocgreis
added
doc
| ``` | ||
| $ node -e "console.log('Hello from Node.js ' + process.version)" | ||
| ```text | ||
| > Release\node -e "console.log('Hello from Node.js ' + process.version)" |
There was a problem hiding this comment.
might be nice to update this, either console.log(Hello from Node.js ${process.version}) or console.log('Hello from Node.js', process.version)
|
lgtm sans suggestions |
|
LGTM |
|
Updated, will land in two days if there are no objections (this is straightforward but not urgent). @rvagg Used the second option for the Thanks for the reviews! |
|
@joshgav @AndrewPardoe @mousetraps let me know if you have any remarks, or want more time to review and discuss. If not, I'll land this next week. Thanks! |
|
LGTM, thanks. |
joaocgreis
added a commit
that referenced
this pull request
Jun 23, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions. Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #7285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
The Visual C++ Build Tools are supported to build Node on Windows and already used in CI, so they should be included in the build instructions.
Corrected the test command to run on Windows after compiling.
cc @nodejs/platform-windows