benchmark: fix child-process-exec-stdout on win #7178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows.
nodejs-github-bot
added
the
benchmark
|
cc @nodejs/platform-windows |
mscdex
added
child_process
|
/cc @Trott |
|
LGTM |
1 similar comment
|
LGTM |
orangemocha
pushed a commit
that referenced
this pull request
Jun 10, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
|
CI is green: https://ci.nodejs.org/job/node-test-pull-request/2974/ Landed in 5386b23. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Jun 16, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Merged
|
@orangemocha should this be landed in lts? |
|
@thealphanerd I would say yes, though it's not critical. |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: #7178 Reviewed-By: Trott - Rich Trott <[email protected]> Reviewed-By: orangemocha - Alexis Campailla <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
benchmark
Description of change
This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.
cc @nodejs/benchmarking