buffer: do not crash in Debug build #7148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `SetupBufferJS` creating `Uint32Array` requires 4 bytes for each entry, while the underlying `ArrayBuffer` was only 1 byte long. Use `Uint8Array` instead.
nodejs-github-bot
added
the
c++
|
alternative fix: #7142 ;) |
addaleax
added
dont-land-on-v5.x
buffer
|
Your fix is better, @addaleax . Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
In
SetupBufferJScreatingUint32Arrayrequires 4 bytes foreach entry, while the underlying
ArrayBufferwas only 1 byte long. UseUint8Arrayinstead.R = @bnoordhuis (cleaning up after your commit 😉 )