debugger: fix --debug-brk interaction with -e #7089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
| agent.stdout.on('data', (chunk) => { | ||
| agentStdout += chunk; | ||
| if (/connecting to .+ ok/.test(agentStdout)) { | ||
| if (needToExit) { |
There was a problem hiding this comment.
Suggestion: fold this into the previous if statement like you do with the outermost if statement. Saves a level of indent.
|
LGTM. We have the means to fix the setTimeout hack now so that would be a good next step. |
|
LGTM |
The command line flag `--debug-brk` was ignored when the `-e` flag was also present. This change allows the flags to both be honored when they are used in a single command line. Fixes: nodejs#3589
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 4, 2016
The command line flag `--debug-brk` was ignored when the `-e` flag was also present. This change allows the flags to both be honored when they are used in a single command line. PR-URL: nodejs#7089 Fixes: nodejs#3589 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1a21524 |
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
The command line flag `--debug-brk` was ignored when the `-e` flag was also present. This change allows the flags to both be honored when they are used in a single command line. PR-URL: #7089 Fixes: #3589 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
|
@Trott lts? |
|
@thealphanerd If it lands cleanly, yes. |
|
this one didn't land cleanly so sad 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
debugger
Description of change
The command line flag
--debug-brkwas ignored when the-eflag wasalso present. This change allows the flags to both be honored when they
are used in a single command line.
Fixes: #3589
This changes some stack traces due to its modifications to lib/internal/bootstrap_node.js. Not sure if that's considered undesirable or not, but I imagine it could be modified to avoid that. See changes to expected output of messages tests to see what the changes are.
Not sure if this fixes a valid use case or not, but there's an issue open for it and there seems to be a history. @bnoordhuis surely knows more.
R=@bnoordhuis? @indutny?