Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 6907 to v4.x (console.* not working when running out of stack space) #6957

Closed
wants to merge 4 commits into from

Commits on May 24, 2016

  1. lib,test,tools: alignment on variable assignments

    Correct alignment on variable assignments that span multiple lines in
    preparation for lint rule to enforce such alignment.
    
    PR-URL: nodejs#6869
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Trott authored and Myles Borins committed May 24, 2016
    Configuration menu
    Copy the full SHA
    23acece View commit details
    Browse the repository at this point in the history
  2. tools: lint for alignment of variable assignments

    Enforce alignment/indentation on variable assignments that span multiple
    lines.
    
    PR-URL: nodejs#6869
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Trott authored and Myles Borins committed May 24, 2016
    Configuration menu
    Copy the full SHA
    146364b View commit details
    Browse the repository at this point in the history

Commits on May 25, 2016

  1. vm: don't abort process when stack space runs out

    Make less assumptions about what objects will be available when
    vm context creation or error message printing fail because V8
    runs out of JS stack space.
    
    Ref: nodejs#6899
    addaleax committed May 25, 2016
    Configuration menu
    Copy the full SHA
    e04fa70 View commit details
    Browse the repository at this point in the history
  2. module: don't cache uninitialized builtins

    Don't cache the exported values of fully uninitialized builtins.
    This works by adding an additional `loading` flag that is only
    active during initial loading of an internal module and checking
    that either the module is fully loaded or is in that state before
    using its cached value.
    
    This has the effect that builtins modules which could not be loaded
    (e.g. because compilation failed due to missing stack space) can be
    loaded at a later point.
    
    Fixes: nodejs#6899
    addaleax committed May 25, 2016
    Configuration menu
    Copy the full SHA
    6b774f7 View commit details
    Browse the repository at this point in the history