Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix formatting issues for child_process docs #6952

Closed
wants to merge 1 commit into from

Conversation

rodmachen
Copy link
Contributor

doc: Fix formatting for child_process docs

Ref: #6911

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, child_process

Description of change

A couple of backspaces had been placed within backticks inside the exec() and execFile() sections. These were not needed due to backtick formatting and have been removed.

The maxBuffer links are affecting readability as they look different than the other bulleted items around them. This styling issue is a WIP.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 24, 2016
@addaleax addaleax added the child_process Issues and PRs related to the child_process subsystem. label May 24, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

LGTM

@eljefedelrodeodeljefe
Copy link
Contributor

Is this finished? Then I'd land it immediately

@rodmachen
Copy link
Contributor Author

The first part (extraneous backslashes) is done, and could be landed immediately.

A discussion on the second part ('maxBuffer' links) has been started on #6911.

eljefedelrodeodeljefe pushed a commit that referenced this pull request May 24, 2016
Ref: #6911
Ref: #5075

PR-URL: #6952
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
@eljefedelrodeodeljefe
Copy link
Contributor

Landed in ed11ac6.

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
Ref: nodejs#6911
Ref: nodejs#5075

PR-URL: nodejs#6952
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Ref: #6911
Ref: #5075

PR-URL: #6952
Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants