test: move uncoupled debugger tests to sequential

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

test debugger

Description of change

Move tests from test/debugger to test/sequential so that they are
exercised by CI and make test. This change only moves tests that have
no dependencies that break when moved to a different directory.

The remaining tests can move in a subsequent PR that will have other (minor) changes required so the tests can run in sequential.

/cc @bnoordhuis @santigimeno

[santigimeno]

LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/2628/

[cjihrig]

LGTM in theory. The CI seemed to have a bad time though.

[Trott]

Ugh. I think I see what the problem is, but uh, small steps first. It looks like one of the tests moved is working A-OK in CI so let's move that one first... moved the others back and force pushed...

CI: https://ci.nodejs.org/job/node-test-commit/3350/

[Trott]

(Amended commit message and force pushed.)

[Trott]

CI is green.

[jasnell]

LGTM but I'm wondering if we should hold off a bit to see what's causing the others to fail.

[Trott]

@jasnell I think the others are failing because of a race condition but I'd like to address it separately. Since these tests have not been seeing any activity with any regularity, I guess it's not surprising that they may not be 100% bullet-proof.

I'd prefer to move the one working test over by itself so that if something comes up and we do have to revert something somewhere, it's an easy and atomic revert that doesn't affect multiple things at once. The other tests will need to be modified and I'd rather blend the move-as-is commit with those modifications.

[jasnell]

Ok. No problems then
On May 16, 2016 1:07 PM, "Rich Trott" [email protected] wrote:

@jasnell https://github.com/jasnell I think the others are failing
because of a race condition but I'd like to address it separately. Since
these tests have not been seeing any activity with any regularity, I guess
it's not surprising that they may not be 100% bullet-proof.

I'd prefer to move the one working test over by itself so that if
something comes up and we do have to revert something somewhere, it's an
easy and atomic revert that doesn't affect multiple things at once. The
other tests will need to be modified and I'd rather not junk up the
move-as-is commit with those modifications.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6731 (comment)

[Trott]

Landed in 5a5b74a