test: favor strictEqual() in addon test #6704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ assert.throws(function() { | |||
|
|
|||
| setImmediate(common.mustCall(function() { | |||
| for (var i = 0; i < results_arr.length; i++) { | |||
| assert.equal(results_arr[i], | |||
| assert.strictEqual(results_arr[i], | |||
| i, | |||
| `verifyExecutionOrder(${arg}) results: ${results_arr}`); | |||
There was a problem hiding this comment.
Hmmm...we have a custom lint rule for that. I know I made it lenient to avoid false positives, but it really should have flagged that...Will have to take a look
Anyway, yes, I'll fix the alignment!
|
LGTM with nit. |
|
LGTM |
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`.
|
Nit addressed, rebased, force pushed. |
|
LGTM (but I already said that.) |
|
@bnoordhuis wrote:
From http://logs.libuv.org/node-dev/2016-05-06: |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 14, 2016
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`. PR-URL: nodejs#6704 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 517d1da |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Replace `assert.equal()` with `assert.strictEqual()` throughout `addon/make-callback-recurse/test.js`. PR-URL: #6704 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Replace
assert.equal()withassert.strictEqual()throughoutaddon/make-callback-recurse/test.js.