test: abstract skip functionality to common #6697
Conversation
| @@ -7,7 +7,7 @@ const assert = require('assert'); | |||
| const skipMessage = | |||
| '1..0 # Skipped: intensive toString tests due to memory confinements'; | |||
There was a problem hiding this comment.
Oops, still need to fix these!
|
Here's the actual function in |
|
LGTM if CI has no complaints |
|
LGTM |
|
Nit: It might be good to name the function more precisely, as it does not actually skip. It outputs the TAP-formatted skip message. I would expect Totally a nit, feel free to ignore, I know |
|
Maybe just |
|
The reason I went with this is iirc because it causes a skip even if the test fails afterwards? |
|
The more I think about it, I wouldn't expect a |
|
LGTM |
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js PR-URL: nodejs#6697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js PR-URL: #6697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
@Fishrock123 I'm going to put this in dont-land-in-lts but please feel free to do a manual backport |
|
Huh. Backporting doesn't seem to work at all. 10 obscure errors. I'll just redo the patch for v4.x, it shoudn't be difficult, and this will likely cause backport conflicts if we don't. |
|
@Fishrock123 that's what I figured would happen. Totally up for the manual backport thanks 👍 |
|
backport @ #7114 |
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of 52bae22 for v4.x Ref: #6697 PR-URL: #7114 Reviewed-By: Myles Borins <[email protected]>
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of 52bae22 for v4.x Ref: #6697 PR-URL: #7114 Reviewed-By: Myles Borins <[email protected]>
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of 52bae22 for v4.x Ref: #6697 PR-URL: #7114 Reviewed-By: Myles Borins <[email protected]>
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of 52bae22 for v4.x Ref: #6697 PR-URL: #7114 Reviewed-By: Myles Borins <[email protected]>
Checklist
Affected core subsystem(s)
test
Description of change
The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js
cc @nodejs/testing