tls,https: respect address family when connecting #6654
Conversation
bnoordhuis
added
tls
|
CI failed to start. https://ci.nodejs.org/job/node-test-pull-request/2549/console LGTM if CI comes up green |
|
Added a fix-up for the CI hosts where |
|
That only made it worse... @nodejs/build Can this be fixed on the buildbots? |
|
@bnoordhuis to be clear you want |
|
..or is it just whatever |
|
@jbergstroem Ideally, I'd like AAAA queries for We currently have this list but trying them in order still doesn't make the tests pass on all machines, see e.g. debian8-x86 (but not debian8-64, oddly enough.) |
|
@bnoordhuis the reason they differ is because one is from DO and the other from softlayer. providers usually populate differently. I'll look at adding |
|
I'm marking the tests as flaky on Linux for now, pending resolution of nodejs/build#415. New CI: https://ci.nodejs.org/job/node-test-pull-request/2815/ |
| const https = require('https'); | ||
|
|
||
| if (!common.hasIPv6) { | ||
| console.log('1..0 # Skipped: no IPv6 support'); |
There was a problem hiding this comment.
Can you switch to the new common.skip().
|
LGTM with a couple comments. |
|
Good points. Updated with feedback. New CI: https://ci.nodejs.org/job/node-test-pull-request/2838/ EDIT: Make that https://ci.nodejs.org/job/node-test-pull-request/2839/ - I just landed #7037 to get the CI in a good state again. |
|
Still |
|
Should be better now. New CI: https://ci.nodejs.org/job/node-test-pull-request/2840/ |
|
All green now. |
Respect the `{ family: 6 }` address family property when connecting to
a remote peer over TLS.
Fixes: nodejs#4139
Fixes: nodejs#6440
PR-URL: nodejs#6654
Reviewed-By: Colin Ihrig <[email protected]>
Update parallel/test-http-agent-getname to use assert.strictEqual() consistently and const-ify variables while we're here. PR-URL: nodejs#6654 Reviewed-By: Colin Ihrig <[email protected]>
Respect the `{ family: 6 }` address family property when connecting to
a remote peer over TLS.
Fixes: nodejs#4139
Fixes: nodejs#6440
PR-URL: nodejs#6654
Reviewed-By: Colin Ihrig <[email protected]>
Update parallel/test-http-agent-getname to use assert.strictEqual() consistently and const-ify variables while we're here. PR-URL: nodejs#6654 Reviewed-By: Colin Ihrig <[email protected]>
Respect the `{ family: 6 }` address family property when connecting to
a remote peer over TLS.
Fixes: #4139
Fixes: #6440
PR-URL: #6654
Reviewed-By: Colin Ihrig <[email protected]>
Update parallel/test-http-agent-getname to use assert.strictEqual() consistently and const-ify variables while we're here. PR-URL: #6654 Reviewed-By: Colin Ihrig <[email protected]>
Respect the `{ family: 6 }` address family property when connecting to
a remote peer over TLS.
Fixes: #4139
Fixes: #6440
PR-URL: #6654
Reviewed-By: Colin Ihrig <[email protected]>
Update parallel/test-http-agent-getname to use assert.strictEqual() consistently and const-ify variables while we're here. PR-URL: #6654 Reviewed-By: Colin Ihrig <[email protected]>
Respect the `{ family: 6 }` address family property when connecting to
a remote peer over TLS.
Fixes: #4139
Fixes: #6440
PR-URL: #6654
Reviewed-By: Colin Ihrig <[email protected]>
Update parallel/test-http-agent-getname to use assert.strictEqual() consistently and const-ify variables while we're here. PR-URL: #6654 Reviewed-By: Colin Ihrig <[email protected]>
Was previously 4.x for ES6 goodies. Now v4.5 to fix issues with TLS and IPv6 not playing nicely together, which meant that you couldn't connected to IRC networks over TLS with IPv6. See: - nodejs/node#6654
Respect the
{ family: 6 }address family property when connecting toa remote peer over TLS.
Fixes: #6440
CI: https://ci.nodejs.org/job/node-test-pull-request/2549/