Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: v8 functions as methods on v8 #6615

Closed
wants to merge 1 commit into from
Closed

doc: v8 functions as methods on v8 #6615

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented May 6, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

For consistency with other docs, show v8 functions as being on the v8
object.

@bengl
doc: v8 functions as methods on v8
80cb399 
For consistency with other docs, show v8 functions as being on the v8
object.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 6, 2016
@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label May 6, 2016
@bnoordhuis
Copy link
Member

LGTM

4 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented May 6, 2016

LGTM

@targos
Copy link
Member

targos commented May 6, 2016

LGTM

@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

targos pushed a commit that referenced this pull request May 9, 2016
@bengl @targos
doc: v8 functions as methods on v8
95d0fee 
For consistency with other docs, show v8 functions as being on the v8
object.

PR-URL: #6615
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@targos
Copy link
Member

targos commented May 9, 2016

landed in 95d0fee

@targos targos closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bengl @evanlucas
doc: v8 functions as methods on v8
fa94a91 
For consistency with other docs, show v8 functions as being on the v8
object.

PR-URL: #6615
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bengl @bnoordhuis @cjihrig @jasnell @targos @Qard @mscdex @MylesBorins @nodejs-github-bot