src: squelch -Wunused-variable in non-icu builds #6351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
the
lib / src
nodejs-github-bot
added
the
c++
|
LGTM. Good catch. Thank you |
|
LGTM |
Silence the following compiler warning when building without ICU:
../src/node_config.cc:32:16: warning: unused variable 'env'
[-Wunused-variable]
Environment* env = Environment::GetCurrent(context);
PR-URL: nodejs#6351
Reviewed-By: James M Snell <[email protected]>
bnoordhuis
force-pushed
the
squelch-warning
branch
from
e1ec8b1 to
5eb4ec0
Compare
|
Sorry @addaleax, missed your comment. |
|
@bnoordhuis nevermind :) |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Silence the following compiler warning when building without ICU:
../src/node_config.cc:32:16: warning: unused variable 'env'
[-Wunused-variable]
Environment* env = Environment::GetCurrent(context);
PR-URL: nodejs#6351
Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Silence the following compiler warning when building without ICU:
../src/node_config.cc:32:16: warning: unused variable 'env'
[-Wunused-variable]
Environment* env = Environment::GetCurrent(context);
PR-URL: #6351
Reviewed-By: James M Snell <[email protected]>
|
Marking as don't land for now... please update if I am incorrect and it should be backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@jasnell
CI: https://ci.nodejs.org/job/node-test-pull-request/2368/