build: fix DESTCPU detection on non-Intel platforms #6310
Conversation
|
cc @mhdawson |
|
Just wondering which case this covers: +ifeq ($(findstring powerpc,$(shell uname -p)),powerpc) +DESTCPU ?= ppc +else otherwise LGTM |
|
That case covers AIX. |
|
@nodejs/build |
|
Note about the implementation: With regards to host architecture detection there are two other places this is done in the build scripts:
|
richardlau
force-pushed
the
fix-arch-detection
branch
from
dec85d5
to
fde7310
Compare
|
@mhdawson I've updated the commit so on AIX it defaults to 64-bit as we discussed on the phone. |
richardlau
force-pushed
the
fix-arch-detection
branch
from
fde7310
to
3afb621
Compare
|
LGTM |
|
@jbergstroem just wondering if you can take a quick look and let me know if you have any concerns with this. |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4
to
c7066fb
Compare
|
I can't claim to know enough of this to stamp it, but since it uses only However, at least ARM64 is missing: $ uname -m
aarch64 |
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture.
richardlau
force-pushed
the
fix-arch-detection
branch
from
3afb621
to
972cb47
Compare
|
Thanks, rebased onto latest master and added aarch64. |
|
ci: https://ci.nodejs.org/job/node-test-pull-request/2614/ overall the changes to the makefile LGTM How was ppc + arm being detected and built correctly before? |
|
sgtm might be time to pull out all of this ARCH and DESTCPU stuff into a script (bash or perl) in tools |
|
@rvagg we could use python's |
|
@jbergstroem sounds good. To clarify though, that shouldn't hold up this PR if the IBM folks agree. @thealphanerd we manually specify both |
|
@rvagg we don't manually specify it on all our machines; mainly release-related stuff -- I think we should avoid it where possible since we'd be testing the configure process as well. With that said, in cases we have to, we should obviously override (esp |
|
LGTM from me as well btw. Just haven't tried all variations of |
|
Looks like we have enough LGTMs to land, will do that now |
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed as 830a726 |
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
`make binary` attempts to auto detect DESTCPU if not set, but was assuming being on an Intel architecture. PR-URL: #6310 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Checklist
Affected core subsystem(s)
build
Description of change
make binaryattempts to auto detectDESTCPUif not set, but wasassuming being on an Intel architecture (i.e. it was checking for x64
and assuming x86 otherwise).