deps: upgrade to V8 5.0.71.33 #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM |
|
LGTM. |
|
LGTM |
1 similar comment
|
LGTM |
|
Yes pleas. LGTM. |
|
LGTM |
This picks up the fix for harmony-regexp-properties being enabled without a flag. V8-Commit: v8/v8@27ac008 Fixes: nodejs#6251 PR-URL: nodejs#6290 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: ChALkeR - Сковорода Никита Андреевич <[email protected]> Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
|
Thanks. Landed as 4fbd375. |
|
awesome... thanks @ofrobots ! |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
This picks up the fix for harmony-regexp-properties being enabled without a flag. V8-Commit: v8/v8@27ac008 Fixes: nodejs#6251 PR-URL: nodejs#6290 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: ChALkeR - Сковорода Никита Андреевич <[email protected]> Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
This picks up the fix for harmony-regexp-properties being enabled without a flag. V8-Commit: v8/v8@27ac008 Fixes: #6251 PR-URL: #6290 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: ChALkeR - Сковорода Никита Андреевич <[email protected]> Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
deps
Description of change
This picks up the fix for harmony-regexp-properties being enabled
without a flag.
V8-Commit: v8/v8@27ac008
Fixes: #6251
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/2331/