test: spawn new processes in vm-cached-data #6280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 may start caching scripts from the first run soon. Preventively execute scripts in another process to ensure no test failures due to an update in the future. See: nodejs#6258
indutny
force-pushed
the
fix/use-spawn-sync-in-vm-cached-data
branch
from
57da6a7
to
7c07bd8
Compare
|
cc @jeisinger |
mscdex
added
vm
|
cool, LGTM |
| assert(!script.cachedDataProduced || script.cachedData instanceof Buffer); | ||
|
|
||
| if (script.cachedDataProduced) | ||
| script.cachedData.toString('base64'); |
There was a problem hiding this comment.
The return value isn't used. I think you intended to console.log or process.stdout.write it?
There was a problem hiding this comment.
It is JS, the last statement will be printed when using -p argv.
There was a problem hiding this comment.
Hm, very subtle. I guess it's not wrong but it's not very obviously correct, either. I'd use -e and explicitly print it.
|
LGTM but with a strong suggestion to change the test. |
|
|
||
| return script.cachedData; | ||
| return new Buffer(out.stdout.toString(), 'base64'); |
There was a problem hiding this comment.
Buffer.from(out.stdout.toString(), 'base64')
|
LGTM with a nit if CI is green |
|
|
||
| let data; | ||
| for (var i = 0; i < ${count}; i++) { | ||
| var script = new vm.Script(process.argv[1], { |
There was a problem hiding this comment.
Just for my understanding, process.argv[1] === undefined here, right?
There was a problem hiding this comment.
It is not, see source on line 32.
There was a problem hiding this comment.
$ node -e 'console.log(process.argv[1])' hello
hello
There was a problem hiding this comment.
Bet you didn't know about this 😉
There was a problem hiding this comment.
Oh, I missed the third argument. Never mind.
|
Landed in e1cf634, thank you everyone! |
indutny
added a commit
that referenced
this pull request
Apr 20, 2016
V8 may start caching scripts from the first run soon. Preventively execute scripts in another process to ensure no test failures due to an update in the future. See: #6258 PR-URL: #6280 Reviewed-By: Jochen Eisinger <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Marking it don't land in v4 simply because the future update to v8 does not apply |
|
marking dont-land-on-v5.x for the same reason. edit: if we want to backport we can use the commit above. I'll likely delete that branch in the next week if we do not opt for landing it |
2 tasks
ofrobots
added a commit
to ofrobots/node
that referenced
this pull request
Apr 20, 2016
V8 may cache compiled scripts, and it is not safe to assume that the V8 flags can be changed after an isolate has been created. In this particular case, since we are using the same script multiple times, the test would fail if V8 cached the result of the compilation. Ref: nodejs#6280 Fixes: nodejs#6258
ofrobots
added a commit
that referenced
this pull request
Apr 21, 2016
V8 may cache compiled scripts, and it is not safe to assume that the V8 flags can be changed after an isolate has been created. In this particular case, since we are using the same script multiple times, the test would fail if V8 cached the result of the compilation. Ref: #6280 Fixes: #6258 PR-URL: #6316 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
V8 may start caching scripts from the first run soon. Preventively execute scripts in another process to ensure no test failures due to an update in the future. See: nodejs#6258 PR-URL: nodejs#6280 Reviewed-By: Jochen Eisinger <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
V8 may cache compiled scripts, and it is not safe to assume that the V8 flags can be changed after an isolate has been created. In this particular case, since we are using the same script multiple times, the test would fail if V8 cached the result of the compilation. Ref: nodejs#6280 Fixes: nodejs#6258 PR-URL: nodejs#6316 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
V8 may start caching scripts from the first run soon. Preventively execute scripts in another process to ensure no test failures due to an update in the future. See: #6258 PR-URL: #6280 Reviewed-By: Jochen Eisinger <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
V8 may cache compiled scripts, and it is not safe to assume that the V8 flags can be changed after an isolate has been created. In this particular case, since we are using the same script multiple times, the test would fail if V8 cached the result of the compilation. Ref: #6280 Fixes: #6258 PR-URL: #6316 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
May 11, 2016
While `let` no longer needs to run in `strict mode` in v8 5.x it throws in v8 4. This modification will make the test-vm-cached-data work in older version of node. Refs: nodejs#6280 PR-URL: nodejs#6317 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
While `let` no longer needs to run in `strict mode` in v8 5.x it throws in v8 4. This modification will make the test-vm-cached-data work in older version of node. Refs: #6280 PR-URL: #6317 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
V8 may start caching scripts from the first run soon. Preventively
execute scripts in another process to ensure no test failures due to
an update in the future.
See: #6258