Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add addaleax to collaborators #6224

Closed

Conversation

addaleax
Copy link
Member

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add myself :)

@jasnell
Copy link
Member

jasnell commented Apr 15, 2016

+1 LGTM! /cc @Fishrock123

@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Apr 15, 2016
@addaleax addaleax force-pushed the add-addaleax-to-collaborators branch from e1205da to 15e3998 Compare April 15, 2016 17:34
@evanlucas
Copy link
Contributor

LGTM

@@ -168,6 +168,7 @@ information about the governance of the Node.js project, see
### Collaborators

* [AndreasMadsen](https://github.com/AndreasMadsen) - **Andreas Madsen** <[email protected]>
* [addaleax](https://github.com/addaleax) - **Anna Henningsen** <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize by username. Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… updated. 😄

@Trott
Copy link
Member

Trott commented Apr 15, 2016

LGTM with nit.

@addaleax addaleax force-pushed the add-addaleax-to-collaborators branch from 15e3998 to 7009bfd Compare April 15, 2016 17:35
@bnoordhuis
Copy link
Member

LGTM and welcome aboard, Anna.

@Trott
Copy link
Member

Trott commented Apr 15, 2016

LGTM!

:shipit:

@MylesBorins
Copy link
Contributor

LGTM... well deserved

🎉

addaleax added a commit that referenced this pull request Apr 15, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@addaleax
Copy link
Member Author

Landed in 69040d6! 🎉

@addaleax addaleax closed this Apr 15, 2016
@addaleax addaleax deleted the add-addaleax-to-collaborators branch April 15, 2016 17:44
@Fishrock123
Copy link
Contributor

🎉 🎉 🎉

@santigimeno
Copy link
Member

Welcome!

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
PR-URL: nodejs#6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6224
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants