Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rework early debug signal handling #615

Merged
merged 3 commits into from
Jan 28, 2015
Merged

src: rework early debug signal handling #615

merged 3 commits into from
Jan 28, 2015

Commits on Jan 28, 2015

  1. src: do platform-specific initialization earlier 

    Execute the per-platform initialization logic as early as possible,
for two reasons:

1. It opens the way for an upcoming commit to simplify early SIGUSR1
   handling.

2. It should make life easier for embedders because io.js no longer
   mucks around with the file descriptor limit or signal disposition
   of the process.

PR-URL: nodejs#615
Reviewed-By: Sam Roberts <[email protected]>
    @bnoordhuis
    bnoordhuis committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    5756f92 View commit details
    Browse the repository at this point in the history

  2. src: rework early debug signal handling 

    Instead of installing an early debug signal handler, simply block the
SIGUSR1 signal at start-up and unblock it when the debugger is ready.

Both approaches are functionally equivalent but blocking the signal
accomplishes it in fewer lines of code.

PR-URL: nodejs#615
Reviewed-By: Sam Roberts <[email protected]>
    @bnoordhuis
    bnoordhuis committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    63ae1d2 View commit details
    Browse the repository at this point in the history

  3. src: set default signal dispositions at start-up 

    Signal dispositions are inherited by child processes.  Restore ours to
sane defaults in case our parent process changed it, to prevent quirky
behavior when the parent does something silly like ignoring SIGSEGV.

PR-URL: nodejs#615
Reviewed-By: Sam Roberts <[email protected]>
    @bnoordhuis
    bnoordhuis committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    dd47a8c View commit details
    Browse the repository at this point in the history