src: fix -Wunused-variable compiler warning #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check to JS". PR-URL: nodejs#6129 Reviewed-By: Evan Lucas <[email protected]>
bnoordhuis
force-pushed
the
fix-unused-variable-warning
branch
from
79c5e65
to
f938ef7
Compare
|
@bnoordhuis lts? |
|
No. It was introduced by #5834 which is marked dont-land-on-v4.x. I'll add the labels here as well. |
|
@bnoordhuis thanks |
This was referenced May 17, 2016
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check to JS". PR-URL: #6129 Reviewed-By: Evan Lucas <[email protected]>
|
@Fishrock123 why was the dont-land label removed for v4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.