document how to use crypto.sign() for algorithm+digest combinations without named constants #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| sign.update('some data to sign'); | ||
|
|
||
| const privateKey = '-----BEGIN EC PRIVATE KEY-----\n' + |
There was a problem hiding this comment.
Either update this const name to be private_key for consistency, or update the one passed into sign() below.
There was a problem hiding this comment.
Should be camelcase for javascript, so the other should be fixed.
There was a problem hiding this comment.
You are correct that it should be camelCase, but the rest of the references in the doc use lower_case, so, I agree that consistency with the existing examples wins.
mscdex
added
crypto
|
decided to stick with private_key for consistency with all other examples in the doc. |
|
LGTM |
|
LGTM |
| 'MHcCAQEEIF+jnWY1D5kbVYDNvxxo/Y+ku2uJPDwS0r/VuPZQrjjVoAoGCCqGSM49\n' + | ||
| 'AwEHoUQDQgAEurOxfSxmqIRYzJVagdZfMMSjRNNhB8i3mXyIMq704m2m52FdfKZ2\n' + | ||
| 'pQhByd5eyj3lgZ7m7jbchtdgyOF8Io/1ng==\n' + | ||
| '-----END EC PRIVATE KEY-----\n', |
jasnell
pushed a commit
that referenced
this pull request
Apr 8, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 8, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
|
Fixed the nit with the comma and landed in 9454548 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
PR-URL: #6108 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updates the crypto API documentation to demonstrate how to use signature algorithms supported by OpenSSL but not exposed as named constants, e.g. "ecdsa-with-SHA256".