Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix sporadic deadlock in SIGUSR1 handler #5904

Merged
merged 1 commit into from
May 10, 2016
Merged

src: fix sporadic deadlock in SIGUSR1 handler #5904

merged 1 commit into from
May 10, 2016

Commits on May 10, 2016

  1. src: fix sporadic deadlock in SIGUSR1 handler 

    Calling v8::Debug::DebugBreak() directly from the signal handler is
unsafe because said function tries to grab a mutex.  Work around that
by starting a watchdog thread that is woken up from the signal handler,
which then calls v8::Debug::DebugBreak().

Using a watchdog thread also removes the need to use atomic operations
so this commit does away with that.

Fixes: nodejs#5368
PR-URL: nodejs#5904
Reviewed-By: Anna Henningsen <[email protected]>
    @bnoordhuis
    bnoordhuis committed May 10, 2016
    Configuration menu
    Copy the full SHA
    844f0a9 View commit details
    Browse the repository at this point in the history