Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updated fs #5877

Closed
wants to merge 2 commits into from
Closed

doc: updated fs #5877

wants to merge 2 commits into from

Conversation

ToPal
Copy link

@ToPal ToPal commented Mar 23, 2016

See issue #5862.
Removed irrelevant data about fs.readFile in docs for version 4.x

nodejs#5862
removed irrelevant data about fs.readFile
@ToPal ToPal mentioned this pull request Mar 23, 2016
@mscdex mscdex added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Mar 23, 2016
@benjamingr
Copy link
Member

LGTM.

@targos
Copy link
Member

targos commented Mar 23, 2016

The same correction is needed for fs.writeFile() and fs.appendFile()

nodejs#5862
removed irrelevant data about fs.writeFile and fs.appendFile
@ToPal
Copy link
Author

ToPal commented Mar 24, 2016

@targos ok, I've fixed it

@targos
Copy link
Member

targos commented Mar 24, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Mar 24, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 24, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.

PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 24, 2016

Landed in v4.x-staging in 2d65b05

@jasnell jasnell closed this Mar 24, 2016
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.

PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
fs.readFile, fs.writeFile and fs.appendFile doc changes
pulled back from master included details not relevant to
v4.

PR-URL: #5877
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants