Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add self-assigment memcpy checks #56986

Merged
merged 1 commit into from
Feb 12, 2025
Merged

src: add self-assigment memcpy checks #56986

merged 1 commit into from
Feb 12, 2025
+6 −2

Conversation

wooffie
Copy link
Contributor

@wooffie wooffie commented Feb 10, 2025 •
edited
Loading

Fixes: #56718

Maybe it's pointless, but imho more clear

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 10, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (1781f63) to head (399dcc4).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sockaddr-inl.h 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56986      +/-   ##
==========================================
+ Coverage   89.11%   89.13%   +0.01%     
==========================================
  Files         665      665              
  Lines      193174   193176       +2     
  Branches    37187    37188       +1     
==========================================
+ Hits       172154   172185      +31     
+ Misses      13754    13745       -9     
+ Partials     7266     7246      -20
Files with missing lines Coverage Δ
src/node_sockaddr-inl.h 84.84% <66.66%> (-0.54%) ⬇️

... and 25 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65123/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65139/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65142/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 85f5a6c into nodejs:main Feb 12, 2025
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 85f5a6c

targos pushed a commit that referenced this pull request Feb 17, 2025
@wooffie @targos
src: add self-assigment memcpy checks
7e2dac9 
Fixes: #56718
PR-URL: #56986
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add self-assignment cases in SocketAddress
4 participants
@wooffie @nodejs-github-bot @jasnell @addaleax