Enable ccache on Windows v2 #56847
Merged
Enable ccache on Windows v2 #56847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
added
windows
|
Review requested:
|
nodejs-github-bot
added
doc
joyeecheung
reviewed
Jan 31, 2025
Prior to these changes compilation with ccache was broken because of the .h file regeneration in each compilation.
Add cp command in building docs Remove CCACHE_USED macro Disable PCH when using Clang and ccache
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
StefanStojanovic
force-pushed
the
mefi-ccache-2
branch
from
9a1c94b to
2e834a1
Compare
|
Thanks for the review and change suggestions @joyeecheung I added one more change missing in |
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Feb 4, 2025
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56847 ✔ Done loading data for nodejs/node/pull/56847 ----------------------------------- PR info ------------------------------------ Title Enable ccache on Windows v2 (#56847) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch StefanStojanovic:mefi-ccache-2 -> nodejs:main Labels doc, windows, install, build, v8 engine, tools, needs-ci Commits 11 - build,win: enable ccache - doc,win: add ccache support - deps: change V8 generated .h files for ccache - fix: resolve PR comments - Update configure.py - Update configure.py - Update configure.py - Update configure.py - Update tools/v8_gypfiles/v8.gyp - Update common.gypi - Update vcbuild.bat Committers 1 - StefanStojanovic <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56847 Refs: https://github.com/nodejs/node/pull/56705 Reviewed-By: Joyee Cheung <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56847 Refs: https://github.com/nodejs/node/pull/56705 Reviewed-By: Joyee Cheung <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 31 Jan 2025 15:39:33 GMT ✔ Approvals: 1 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/56847#pullrequestreview-2593989152 ✘ This PR needs to wait 26 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-04T20:38:28Z: https://ci.nodejs.org/job/node-test-pull-request/64994/ - Querying data for job/node-test-pull-request/64994/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13179308049 |
StefanStojanovic
removed
the
commit-queue-failed
targos
approved these changes
Feb 9, 2025
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a017307 |
targos
pushed a commit
that referenced
this pull request
Feb 10, 2025
PR-URL: #56847 Refs: #56705 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of work that started here and considers review comments. Since there were 2 potential approaches, this PR implements the one not represented in the previous PR. For more details, you can just read that one's description, but in short, the idea here is to disable PCH when using ccache and Clang (MSVC cannot compile with PCH). This makes initial compilation twice as long as when using PCH, but the following ones are much faster.
The fIrst 3 commits in this PR are the same as the ones in the previous ones, the only difference is the 4th one.
Refs: #56705