-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: getMaxListeners detects 0 listeners #56807
events: getMaxListeners detects 0 listeners #56807
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56807 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 663 663
Lines 192012 192012
Branches 36927 36928 +1
=======================================
Hits 171296 171296
+ Misses 13586 13578 -8
- Partials 7130 7138 +8
|
Forgive my lack of process knowledge: what is the flow to make sure this gets backported to v22 (as it follows the backported change)? Should this PR have a label to be picked up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@slagiewka, this can be backported once it has been on a Current release for at least two weeks, no label needed. |
Landed in 752c0b8 |
PR-URL: #56807 Refs: nodejs/undici#4032 Refs: c1ccade Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
With the removal of the max listeners warning from AbortSignal, a bug was surfaced with getMaxListeners.
This causes performance issues for undici.
Refs: nodejs/undici#4032
Refs: c1ccade