Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] deps: V8: backport 9ab40592f697 #56782

Closed
wants to merge 1 commit into from
Closed

[v20.x backport] deps: V8: backport 9ab40592f697 #56782

wants to merge 1 commit into from
+7 −7

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Jan 27, 2025

Manual backport for v20.x of #56781

Original commit message:

[riscv] Flush icache in both local and remote harts

Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jan 27, 2025
@kxxt kxxt mentioned this pull request Jan 27, 2025
Merged
@aduh95 aduh95 changed the title deps: V8: backport 9ab40592f697 [v20.x backport] deps: V8: backport 9ab40592f697 Jan 27, 2025
@aduh95
Copy link
Contributor

aduh95 commented Jan 27, 2025

We'd need to wait for #56781 to land, and we should amend the commit message to use the metadata of the other PR

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Jan 27, 2025
@kxxt
updpatch: nodejs 23.4.0-1
84cf8d0 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
@kxxt kxxt mentioned this pull request Jan 27, 2025
Merged
kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Jan 27, 2025
@kxxt
updpatch: nodejs 23.4.0-1
c1addc7 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Jan 28, 2025
@kxxt @felixonmars
updpatch: nodejs 23.4.0-1
330c57b 
- Switch compiler to clang, this workarounds https://archriscv.felixc.at/.status/log.htm?url=logs/389-ds-base/389-ds-base-3.1.1-3.log
  See more details in riscv-forks/electron#7
- Cherry-pick icache flush fix, upstreamed:
  - nodejs/node#56781
  - nodejs/node#56782
- Should still need nocheck
@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64808/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6379/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6379/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6379/

@marco-ippolito
Copy link
Member

can you rebase please, the issue on smartos should have been fixed.

@luyahan @kxxt
deps: V8: backport 9ab40592f697
2baef44 
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059
Co-authored-by: kxxt <[email protected]>
@kxxt
Copy link
Contributor Author

kxxt commented Feb 11, 2025

can you rebase please, the issue on smartos should have been fixed.

Rebased. Thanks for the ping.

BTW should I do anything manually targeting v22.x. #56781 should apply to v22.x (except the v8_embedder_string part). Are there any automatic way to pick #56781 into v22.x or should I open another PR like this one?

@marco-ippolito
Copy link
Member

If lands cleanly it will be picked up automatically

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65137/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6408/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6408/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6408/

@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 11, 2025 •
edited
Loading

Landed in 5c9a397

marco-ippolito pushed a commit that referenced this pull request Feb 11, 2025
@luyahan @marco-ippolito
deps: V8: backport 9ab40592f697
f438c2a 
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059
PR-URL: #56781
Backport-PR-URL: #56782
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 11, 2025
@luyahan @kxxt @marco-ippolito
deps: V8: backport 9ab40592f697
5c9a397 
Original commit message:

    [riscv] Flush icache in both local and remote harts

    Fix the I-Cache flush flag according to the implementation of flush_icache_mm in Linux kernel.

    Change-Id: I6e6b1f56c377c2c0a629e170737bfac6c357ce8d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6080611
    Commit-Queue: Yahan Lu (LuYahan) <[email protected]>
    Reviewed-by: Ji Qiu <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#97673}

Refs: v8/v8@9ab4059
PR-URL: #56781
Backport-PR-URL: #56782
Co-authored-by: kxxt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kxxt @nodejs-github-bot @aduh95 @marco-ippolito @targos @richardlau @luyahan