test_runner: finish marking snapshot testing as stable #56425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Jan 1, 2025
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Jan 1, 2025
atlowChemi
approved these changes
Jan 1, 2025
JakobJingleheimer
approved these changes
Jan 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56425 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 657 657
Lines 190718 190738 +20
Branches 36603 36609 +6
==========================================
+ Hits 168861 168869 +8
- Misses 15024 15041 +17
+ Partials 6833 6828 -5
|
Snapshot testing was marked stable in nodejs#55897. These were overlooked at the time. Refs: nodejs#55897
github-actions
bot
removed
the
request-ci
pmarchini
approved these changes
Jan 2, 2025
cjihrig
added
author ready
MoLow
approved these changes
Jan 2, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in afafee2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot testing was marked stable in #55897. These were overlooked at the time.
Refs: #55897