src: lock the thread properly in snapshot builder #56327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it can crash DCHECK when V8 expects that at least someone is locking the current thread.
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56327 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 657 657
Lines 190295 190394 +99
Branches 36536 36544 +8
=======================================
+ Hits 168491 168582 +91
- Misses 14981 14991 +10
+ Partials 6823 6821 -2
|
|
Just to help me understand, do we have to lock because of this check? |
jasnell
approved these changes
Dec 28, 2024
legendecas
approved these changes
Dec 31, 2024
JungMinu
approved these changes
Jan 1, 2025
addaleax
approved these changes
Jan 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Yes, it's not technically serious for us to not lock it because we don't have other threads trying to take over the isolate here, but V8 uses it as a shortcut for current thread check, so it's needed to circumvent the DHCECK. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7c3aa9f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it can crash DCHECK when V8 expects that at least someone is locking the current thread.
Fixes: nodejs/node-v8#294