Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden #56290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,19 @@
['clang==0 and OS!="win"', {
'cflags': [ '-Wno-restrict', ],
}],
# TODO(joyeecheung): investigate if it breaks addons.
# ['OS=="mac"', {
# 'xcode_settings': {
# 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
# 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
# },
# }],
# ['OS!="win" or clang==1', {
# 'cflags': [
# '-fvisibility=hidden',
# '-fvisibility-inlines-hidden'
# ],
# }],
# Pointer authentication for ARM64.
['target_arch=="arm64"', {
'target_conditions': [
Expand Down
21 changes: 15 additions & 6 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,26 @@
}
},
'conditions': [
# Build with -fvisibility=hidden and -fvisibility-inlines-hidden to avoid
# including unnecessary internal symbols, which may lead to run-time fixups.
# This is not done on AIX where symbols are exported by tools/create_expfile.sh
# see https://github.com/nodejs/node/pull/56290#issuecomment-2582703109
['OS!="aix"', {
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
]
}],
['OS=="mac"', {
# Hide symbols that are not explicitly exported with V8_EXPORT.
# TODO(joyeecheung): enable it on other platforms. Currently gcc times out
# or run out of memory with -fvisibility=hidden on some machines in the CI.
'xcode_settings': {
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES' # -fvisibility-inlines-hidden
},
'defines': [
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
}, 'OS!="aix" and (OS!="win" or clang==1)', {
'cflags': [
'-fvisibility=hidden',
'-fvisibility-inlines-hidden'
],
}],
}], # MSVC hides the non-public symbols by default so no need to configure it.
],
},
'targets': [
Expand Down
Loading