-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] test: Migrate tests to use node:test module for better test structure #56024
base: main
Are you sure you want to change the base?
[wip] test: Migrate tests to use node:test module for better test structure #56024
Conversation
f8848ba
to
91ea1ed
Compare
39a2917
to
c0d09d1
Compare
Please wait for #56027 before continuing on this work. |
Also, a single pull-request with 1000 lines changes is extremely hard to review. I recommend splitting this, and justifying the reasoning behind this change. |
thank you very much for the suggestion, I will divide this pr as you said, I can even link it into a topic or tasks @anonrig |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56024 +/- ##
=======================================
Coverage 87.95% 87.96%
=======================================
Files 656 656
Lines 188372 188372
Branches 35979 35975 -4
=======================================
+ Hits 165687 165694 +7
+ Misses 15851 15839 -12
- Partials 6834 6839 +5 |
@mertcanaltin I've asked you to wait on progressing such changes due to the pending PR and discussion around refactoring node test usage. We are not in alignment to make these kind of changes, yet. |
I understand, I'm very sorry. Should I consider closing these pull requests? 🙏 |
hello I am converting old tests to node:test and I continue to work on it now fyi