doc: add added tag and fix typo sqlite.md #56012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
louwers
changed the title
louwers
changed the title
richardlau
reviewed
Nov 27, 2024
richardlau
approved these changes
Nov 27, 2024
lpinca
approved these changes
Nov 27, 2024
mertcanaltin
approved these changes
Nov 27, 2024
cjihrig
approved these changes
Nov 27, 2024
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56012 ✔ Done loading data for nodejs/node/pull/56012 ----------------------------------- PR info ------------------------------------ Title doc: add added tag and fix typo sqlite.md (#56012) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch louwers:sqlite-docs -> nodejs:main Labels doc, fast-track, author ready, sqlite Commits 1 - doc: add added tag and fix typo sqlite.md Committers 1 - Bart Louwers <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56012 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56012 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 27 Nov 2024 01:47:06 GMT ✔ Approvals: 4 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/56012#pullrequestreview-2463685492 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56012#pullrequestreview-2463688823 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56012#pullrequestreview-2464636343 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56012#pullrequestreview-2465109807 ℹ This PR is being fast-tracked ✘ This PR needs to wait 29 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12057780875 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 853b304 |
aduh95
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #56012 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very cool to see my PR #54181 released!
I noticed that the version added line was missing because I forgot to use
REPLACEME.Also I fixed a typo
databsase->database.