Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve GN build documentation a bit #55968

Merged
merged 1 commit into from
Nov 27, 2024
Merged

doc: improve GN build documentation a bit #55968

merged 1 commit into from
Nov 27, 2024
+31 −22

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 23, 2024 •
edited
Loading

As in title. With my last few commits as well as some i've made upstream to node-ci, the GN build now compiles on Windows:

NORTHAMERICA+cavohr@CODEBYTERE-WIN-WORK CLANGARM64 ~/Developer/node_gn/node ((95ad75b...))
$ ./out/Release/node.exe
Welcome to Node.js v24.0.0-pre.
Type ".help" for more information.
>

This adds some Windows-specific notes to documentation.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 23, 2024
joyeecheung
joyeecheung approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for improving the docs!

@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit c6d3fdd into nodejs:main Nov 27, 2024
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c6d3fdd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol juanarbol approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @joyeecheung @StefanStojanovic @juanarbol @RafaelGSS