crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits #55866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
panva
added
lts-watch-v20.x
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55866 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 654 654
Lines 187852 187852
Branches 36134 36131 -3
=======================================
+ Hits 166102 166103 +1
- Misses 14989 14993 +4
+ Partials 6761 6756 -5
|
KhafraDev
approved these changes
Nov 15, 2024
panva
added
the
author ready
anonrig
approved these changes
Nov 15, 2024
jazelly
approved these changes
Nov 15, 2024
panva
added
the
commit-queue
lpinca
approved these changes
Nov 15, 2024
mertcanaltin
approved these changes
Nov 15, 2024
tniessen
approved these changes
Nov 16, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1618463 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 18, 2024
PR-URL: #55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55866 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the WPTs and implementation to reflect the upstream spec change from w3c/webcrypto#380
The change is done entirely in javascript so that we don't have to change the underlying c++ code which would also affect its corresponding
node:cryptomethods.