Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: consolidate history table of CustomEvent #55758

Merged
merged 1 commit into from
Nov 9, 2024
Merged

doc: consolidate history table of CustomEvent #55758

merged 1 commit into from
Nov 9, 2024

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Nov 7, 2024 •
edited
Loading

Refs: #55733
Fixes: #55733

This PR fixes inconsistencies in the CustomEvent docs by consolidating the history table in globals and events

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2024
@geeksilva97 geeksilva97 marked this pull request as ready for review November 7, 2024 02:29
@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2024
@aduh95 aduh95 added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 8, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2024

I've added the https://github.com/nodejs/node/labels/backport-requested-v22.x label as we'll need a manual backport to remove the mention of changes that are not on this release line. We could also manually backport it to v20.x, but given that it's in maintenance mode, it's probably not worth it.

@geeksilva97
Copy link
Contributor Author

I've added the https://github.com/nodejs/node/labels/backport-requested-v22.x label as we'll need a manual backport to remove the mention of changes that are not on this release line. We could also manually backport it to v20.x, but given that it's in maintenance mode, it's probably not worth it.

Does it mean I need to open a new PR towards v22.x?

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2024

Does it mean I need to open a new PR towards v22.x?

Once this PR has landed on main, someone (possibly you) would need to cherry-pick the commit from main on top of v22.x-staging, and amend it to remove the changes which are v23.x-specific, and propose that change in a new PR, yes.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 069ec1b into nodejs:main Nov 9, 2024
50 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 069ec1b

@geeksilva97
Copy link
Contributor Author

I will backport :)

aduh95 pushed a commit that referenced this pull request Nov 9, 2024
@geeksilva97 @aduh95
doc: consolidate history table of CustomEvent
355af0f 
PR-URL: #55758
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@aduh95 aduh95 mentioned this pull request Nov 9, 2024
Merged
geeksilva97 added a commit to geeksilva97/node that referenced this pull request Nov 10, 2024
@geeksilva97
doc: consolidate history table of CustomEvent
38d031b 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@geeksilva97 geeksilva97 mentioned this pull request Nov 10, 2024
Closed
@RedYetiDev RedYetiDev added backport-open-v22.x Indicate that the PR has an open backport and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Nov 10, 2024
geeksilva97 added a commit to geeksilva97/node that referenced this pull request Nov 11, 2024
@geeksilva97
doc: consolidate history table of CustomEvent
da5be81 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2024
@geeksilva97 @ruyadorno
doc: consolidate history table of CustomEvent
9ffd2dd 
PR-URL: #55758
Backport-PR-URL: #55805
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@geeksilva97 @tpoisseau
doc: consolidate history table of CustomEvent
ab7c959 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@geeksilva97 @Ceres6
doc: consolidate history table of CustomEvent
6c031a3 
PR-URL: nodejs#55758
Fixes: nodejs#55733
Refs: nodejs#55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@aduh95 aduh95 added backported-to-v23.x PRs backported to the v23.x-staging branch. backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels Nov 26, 2024
@nodejs-github-bot nodejs-github-bot mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeyeon daeyeon daeyeon approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. backported-to-v23.x PRs backported to the v23.x-staging branch. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent version table of CustomEvent
6 participants
@geeksilva97 @aduh95 @nodejs-github-bot @lpinca @daeyeon @RedYetiDev