Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove mention of ECDH-ES in crypto.diffieHellman #55611

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

panva
Copy link
Member

@panva panva commented Oct 30, 2024

EC, X448 and X25519 are all ECDH, ECDH-ES in here might have been a reference to the JWA algorithm identifier 🤷

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Oct 30, 2024
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 31, 2024
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit ba8fc73 into nodejs:main Nov 2, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba8fc73

@panva panva deleted the dh-docs-cleanup branch November 2, 2024 12:38
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
aduh95 pushed a commit that referenced this pull request Nov 5, 2024
PR-URL: #55611
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
PR-URL: #55611
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
PR-URL: #55611
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
PR-URL: #55611
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants