-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typings: fix ModulesBinding
types
#55549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobJingleheimer
approved these changes
Oct 26, 2024
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 26, 2024
marco-ippolito
approved these changes
Nov 2, 2024
marco-ippolito
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 2, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 2, 2024
Commit Queue failed- Loading data for nodejs/node/pull/55549 ✔ Done loading data for nodejs/node/pull/55549 ----------------------------------- PR info ------------------------------------ Title typings: fix `ModulesBinding` types (#55549) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:module-binding-types -> nodejs:main Labels author ready, typings Commits 1 - typings: fix `ModulesBinding` types Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55549 Fixes: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55549 Fixes: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 26 Oct 2024 09:16:11 GMT ✔ Approvals: 2 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/55549#pullrequestreview-2397109686 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55549#pullrequestreview-2411266335 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD 10cce655ca..c0db893f04 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 13577d3dbc module: simplify `findPackageJSON` implementation - c0db893f04 module: simplify `findPackageJSON` implementation -------------------------------------------------------------------------------- HEAD is now at c0db893f04 module: simplify `findPackageJSON` implementation ✔ Reset to origin/main - Downloading patch for 55549 From https://github.com/nodejs/node * branch refs/pull/55549/merge -> FETCH_HEAD ✔ Fetched commits as c0db893f04f4..37f0f77f3099 -------------------------------------------------------------------------------- [main 9ebf2997f9] typings: fix `ModulesBinding` types Author: Antoine du Hamel <[email protected]> Date: Sat Oct 26 11:15:04 2024 +0200 1 file changed, 5 insertions(+), 4 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- typings: fix `ModulesBinding` typeshttps://github.com/nodejs/node/actions/runs/11643709674 |
aduh95
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Nov 2, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 2, 2024
Landed in df4a0c9 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55549 Refs: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
aduh95
added a commit
that referenced
this pull request
Nov 5, 2024
PR-URL: #55549 Refs: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
aduh95
added a commit
that referenced
this pull request
Nov 6, 2024
PR-URL: #55549 Refs: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55549 Refs: https://github.com/nodejs/node/pull/55412/files#r1817708918 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v22.x
PRs awaiting manual backport to the v22.x-staging branch.
label
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-requested-v22.x
PRs awaiting manual backport to the v22.x-staging branch.
typings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/pull/55412/files#r1817708918