-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove unneeded listeners #55486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unhandled `'error'` events will make the process exit with an unclean exit code anyway.
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Oct 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55486 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 653 653
Lines 187435 187435
Branches 36077 36073 -4
==========================================
- Hits 165714 165710 -4
+ Misses 14960 14956 -4
- Partials 6761 6769 +8 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 21, 2024
jakecastelli
approved these changes
Oct 23, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 29, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 29, 2024
Landed in 84fe809 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Oct 30, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: nodejs#55486 Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: #55486 Reviewed-By: Jake Yuesong Li <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: nodejs#55486 Reviewed-By: Jake Yuesong Li <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: nodejs#55486 Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: #55486 Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: #55486 Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean exit code anyway. PR-URL: #55486 Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unhandled
'error'
events will make the process exit with an unclean exit code anyway.