Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded listeners #55486

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 21, 2024

Unhandled 'error' events will make the process exit with an unclean exit code anyway.

Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (7bc3e16) to head (fce1755).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55486      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.01%     
==========================================
  Files         653      653              
  Lines      187435   187435              
  Branches    36077    36073       -4     
==========================================
- Hits       165714   165710       -4     
+ Misses      14960    14956       -4     
- Partials     6761     6769       +8     

see 26 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2024
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 84fe809 into nodejs:main Oct 29, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 84fe809

@lpinca lpinca deleted the remove/error-listeners branch October 29, 2024 21:53
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Oct 30, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: nodejs#55486
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: #55486
Reviewed-By: Jake Yuesong Li <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: nodejs#55486
Reviewed-By: Jake Yuesong Li <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: nodejs#55486
Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: #55486
Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: #55486
Reviewed-By: Jake Yuesong Li <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: #55486
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants