-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor project to use PromiseWithResolvers #55436
lib: refactor project to use PromiseWithResolvers #55436
Conversation
Review requested:
|
@@ -47,7 +48,6 @@ const { | |||
|
|||
const { | |||
convertToValidSignal, | |||
createDeferredPromise, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this isn't being used, you can remove it entirely, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it because it was not in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of #54836.
I saw this, I tried to make the places that did not pass, but I forgot that there is no merge yet, I am very sorry, I am closing this pr. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55436 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 653 653
Lines 187604 187601 -3
Branches 36119 36117 -2
=======================================
+ Hits 165849 165863 +14
+ Misses 14983 14973 -10
+ Partials 6772 6765 -7
|
refactor project to use PromiseWithResolvers for lib