Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: refactor project to use PromiseWithResolvers #55436

Closed

Conversation

mertcanaltin
Copy link
Member

refactor project to use PromiseWithResolvers for lib

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 17, 2024
@@ -47,7 +48,6 @@ const {

const {
convertToValidSignal,
createDeferredPromise,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't being used, you can remove it entirely, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because it was not in use

@RedYetiDev RedYetiDev added the promises Issues and PRs related to ECMAScript promises. label Oct 17, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #54836.

@mertcanaltin
Copy link
Member Author

mertcanaltin commented Oct 17, 2024

Duplicate of #54836.

I saw this, I tried to make the places that did not pass, but I forgot that there is no merge yet, I am very sorry, I am closing this pr.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (4d6d7d6) to head (d9118d1).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/watchers.js 66.66% 1 Missing ⚠️
lib/internal/webstreams/adapters.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55436   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         653      653           
  Lines      187604   187601    -3     
  Branches    36119    36117    -2     
=======================================
+ Hits       165849   165863   +14     
+ Misses      14983    14973   -10     
+ Partials     6772     6765    -7     
Files with missing lines Coverage Δ
lib/child_process.js 97.72% <100.00%> (ø)
lib/internal/abort_controller.js 98.05% <100.00%> (ø)
lib/internal/blob.js 99.80% <100.00%> (ø)
lib/internal/test_runner/runner.js 88.92% <100.00%> (ø)
lib/internal/webstreams/readablestream.js 98.32% <100.00%> (ø)
lib/internal/webstreams/transfer.js 98.08% <100.00%> (-0.02%) ⬇️
lib/internal/webstreams/transformstream.js 99.56% <100.00%> (ø)
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (ø)
lib/internal/fs/watchers.js 85.78% <66.66%> (ø)
lib/internal/webstreams/adapters.js 85.42% <83.33%> (ø)

... and 37 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. promises Issues and PRs related to ECMAScript promises.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants