Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram: add UV_UDP_REUSEPORT for udp #55403

Merged
merged 1 commit into from
Oct 21, 2024
Merged

dgram: add UV_UDP_REUSEPORT for udp #55403

merged 1 commit into from
Oct 21, 2024

Conversation

theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Oct 16, 2024 •
edited
Loading

UV_UDP_REUSEPORT allows users to bind a port to multiple sockets.
Refs: libuv/libuv#4419

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Oct 16, 2024
mcollina
mcollina approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63139/

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (7a7c2b3) to head (c563569).
Report is 68 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55403      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186878   187491     +613     
  Branches    36061    36094      +33     
==========================================
+ Hits       165236   165751     +515     
- Misses      14895    14970      +75     
- Partials     6747     6770      +23
Files with missing lines Coverage Δ
lib/dgram.js 97.33% <100.00%> (+0.01%) ⬆️
src/udp_wrap.cc 78.71% <100.00%> (+0.04%) ⬆️

... and 119 files with indirect coverage changes

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63141/

@theanarkh theanarkh force-pushed the add_reuseport_for_udp branch 2 times, most recently from 249aa05 to 67bc2db Compare October 16, 2024 18:11
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63145/

mcollina
mcollina approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63153/

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2024
@addaleax
Copy link
Member

Title should be dgram: add UV_TCP_REUSEPORT, right?

@theanarkh theanarkh changed the title lib: add UV_UDP_REUSEPORT for udp dgram: add UV_UDP_REUSEPORT for udp Oct 17, 2024
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca reviewed Oct 19, 2024
View reviewed changes
doc/api/dgram.md Outdated Show resolved Hide resolved
doc/api/dgram.md Outdated Show resolved Hide resolved
test/common/udp.js Outdated Show resolved Hide resolved
test/common/udp.js Outdated Show resolved Hide resolved
test/common/udp.js Outdated Show resolved Hide resolved
test/parallel/test-child-process-dgram-reuseport.js Outdated Show resolved Hide resolved
test/parallel/test-child-process-dgram-reuseport.js Outdated Show resolved Hide resolved
test/parallel/test-child-process-dgram-reuseport.js Outdated Show resolved Hide resolved
test/parallel/test-cluster-dgram-reuseport.js Outdated Show resolved Hide resolved
test/parallel/test-dgram-reuseport.js Outdated Show resolved Hide resolved
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63207/ 💚

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6a02c27 into nodejs:main Oct 21, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6a02c27

@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 22, 2024
aduh95 pushed a commit that referenced this pull request Oct 23, 2024
@theanarkh @aduh95
lib: add UV_UDP_REUSEPORT for udp
dcbc5fb 
PR-URL: #55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request Oct 24, 2024
@aduh95
2024-10-24, Version 23.1.0 (Current)
dfcd0de 
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) #55398

PR-URL: TODO
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
Merged
aduh95 added a commit that referenced this pull request Oct 24, 2024
@aduh95
2024-10-24, Version 23.1.0 (Current)
17fae65 
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) #55398

PR-URL: #55513
aduh95 added a commit that referenced this pull request Oct 24, 2024
@aduh95
2024-10-24, Version 23.1.0 (Current)
7ddd2c2 
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) #55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) #55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) #55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) #55398

PR-URL: #55513
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@theanarkh @louwers
lib: add UV_UDP_REUSEPORT for udp
878bd56 
PR-URL: nodejs#55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
2024-10-24, Version 23.1.0 (Current)
92e906b 
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) nodejs#55398

PR-URL: nodejs#55513
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@theanarkh @tpoisseau
lib: add UV_UDP_REUSEPORT for udp
f6474a5 
PR-URL: nodejs#55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
2024-10-24, Version 23.1.0 (Current)
61eedb9 
Notable changes:

assert:
  * (SEMVER-MINOR) make `assertion_error` use Myers diff algorithm (Giovanni Bucci) nodejs#54862
buffer:
  * (SEMVER-MINOR) make `Buffer` work with resizable `ArrayBuffer` (James M Snell) nodejs#55377
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) nodejs#55333
lib:
  * (SEMVER-MINOR) add `UV_UDP_REUSEPORT` for udp (theanarkh) nodejs#55403
net:
  * (SEMVER-MINOR) add `UV_TCP_REUSEPORT` for tcp (theanarkh) nodejs#55408
test_runner:
  * mark `MockTimers` as stable (Erick Wendel) nodejs#55398

PR-URL: nodejs#55513
ruyadorno pushed a commit that referenced this pull request Nov 27, 2024
@theanarkh @ruyadorno
lib: add UV_UDP_REUSEPORT for udp
337f61f 
PR-URL: #55403
Refs: libuv/libuv#4419
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
@nodejs-github-bot
2024-12-03, Version 22.12.0 'Jod' (LTS)
70c9947 
Notable changes:

assert:
  * (SEMVER-MINOR) make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make Buffer work with resizable ArrayBuffer (James M Snell) #55377
crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
lib:
  * (SEMVER-MINOR) add UV_UDP_REUSEPORT for udp (theanarkh) #55403
module:
  * (SEMVER-MINOR) unflag --experimental-require-module (Joyee Cheung) #55085
net:
  * (SEMVER-MINOR) add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
sqlite:
  * (SEMVER-MINOR) add support for SQLite Session Extension (Bart Louwers) #54181
tools:
  * fix root certificate updater (Richard Lau) #55681
util:
  * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626

PR-URL: TODO
@nodejs-github-bot nodejs-github-bot mentioned this pull request Nov 27, 2024
Open
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
@nodejs-github-bot
2024-12-03, Version 22.12.0 'Jod' (LTS)
0e31ca5 
Notable changes:

assert:
  * (SEMVER-MINOR) make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make Buffer work with resizable ArrayBuffer (James M Snell) #55377
crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
lib:
  * (SEMVER-MINOR) add UV_UDP_REUSEPORT for udp (theanarkh) #55403
module:
  * (SEMVER-MINOR) unflag --experimental-require-module (Joyee Cheung) #55085
net:
  * (SEMVER-MINOR) add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
sqlite:
  * (SEMVER-MINOR) add support for SQLite Session Extension (Bart Louwers) #54181
tools:
  * fix root certificate updater (Richard Lau) #55681
util:
  * (SEMVER-MINOR) fix util.getCallSites plurality (Chengzhong Wu) #55626

PR-URL: #56040
ruyadorno added a commit that referenced this pull request Nov 28, 2024
@ruyadorno
2024-12-03, Version 22.12.0 'Jod' (LTS)
45c3c19 
Notable changes:

assert:
  * (SEMVER-MINOR) make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make Buffer work with resizable ArrayBuffer (James M Snell) #55377
crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
lib:
  * (SEMVER-MINOR) add UV_UDP_REUSEPORT for udp (theanarkh) #55403
module:
  * (SEMVER-MINOR) unflag --experimental-require-module (Joyee Cheung) #55085
net:
  * (SEMVER-MINOR) add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
sqlite:
  * (SEMVER-MINOR) add support for SQLite Session Extension (Bart Louwers) #54181
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: #56040
ruyadorno added a commit that referenced this pull request Nov 28, 2024
@ruyadorno
2024-12-03, Version 22.12.0 'Jod' (LTS)
2711b68 
Notable changes:

assert:
  * (SEMVER-MINOR) make assertion_error use Myers diff algorithm (Giovanni Bucci) #54862
buffer:
  * (SEMVER-MINOR) make Buffer work with resizable ArrayBuffer (James M Snell) #55377
crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * enforce strict policy to semver-major releases (Rafael Gonzaga) #55732
  * add jazelly to collaborators (Jason Zhang) #55531
esm:
  * mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
lib:
  * (SEMVER-MINOR) add UV_UDP_REUSEPORT for udp (theanarkh) #55403
module:
  * (SEMVER-MINOR) unflag --experimental-require-module (Joyee Cheung) #55085
net:
  * (SEMVER-MINOR) add UV_TCP_REUSEPORT for tcp (theanarkh) #55408
sqlite:
  * (SEMVER-MINOR) add support for SQLite Session Extension (Bart Louwers) #54181
tools:
  * fix root certificate updater (Richard Lau) #55681

PR-URL: #56040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theanarkh @nodejs-github-bot @addaleax @mcollina @jasnell @lpinca