doc: add missing examples and information to fs #55298
Conversation
nodejs-github-bot
added
doc
shrenisc
force-pushed
the
statfs_docs_update
branch
from
e2a544c to
267747e
Compare
|
after research, i confirmed that the js code that I have written follows the cjs format. Could you tell me if there is something else you wanted to be done? |
shrenisc
force-pushed
the
statfs_docs_update
branch
from
267747e to
2af7e01
Compare
|
Hi, are there any more changes needed to be done? |
|
@nodejs/fs PTAL |
shrenisc
force-pushed
the
statfs_docs_update
branch
from
2af7e01 to
24aeb2d
Compare
|
Can you fix the linter issues please? Let me know if you need help |
shrenisc
force-pushed
the
statfs_docs_update
branch
from
24aeb2d to
ff183c0
Compare
I have resolved them now. Thank you |
doc/api/fs.md
Outdated
| const fs = require('node:fs'); | ||
| // Calculate available space in bytes | ||
| fs.statfs('.', (err, stats) => { |
There was a problem hiding this comment.
This isn't the same as the other example:
| const fs = require('node:fs'); | |
| // Calculate available space in bytes | |
| fs.statfs('.', (err, stats) => { | |
| const { statfs } = require('node:fs'); | |
| // Calculate available space in bytes | |
| statfs('.', (err, stats) => { |
There was a problem hiding this comment.
This isn't the same as the other example:
i have corected it now
shrenisc
force-pushed
the
statfs_docs_update
branch
from
ff183c0 to
2d70df3
Compare
|
can i get some help on this error: |
Is this an error you see locally? The output from the CI might be clearer to work with |
no this is a CI error that i see on the checks. |
shrenisc
force-pushed
the
statfs_docs_update
branch
from
2d70df3 to
3a490dd
Compare
|
I am still getting the same error when the PR is checked. |
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: nodejs#50749
added examples and type definitions Fixes:nodejs#50749
added examples and type definitions Fixes:nodejs#50749
shrenisc
force-pushed
the
statfs_docs_update
branch
from
3a490dd to
382edc1
Compare
Hi, can you check now? All checks should pass now. |
Added examples and provided return type definitions
Fixes: #50749