crypto: fix non-multiple of 8 in SubtleCrypto.deriveBits #55296
Closed
+28
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
|
@jasnell do you remember what lead to the current implementation which follows neither the docs nor the spec? |
anonrig
reviewed
Oct 6, 2024
|
@panva ... sorry! I just spotted this one!
I think it's just a bug. |
jasnell
approved these changes
Nov 5, 2024
panva
removed
the
semver-major
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/11860937753 |
panva
removed
the
request-ci-failed
|
Firefox has updated their implementation, i think it's alright to follow suit with this. Question is whether major or not? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55296 +/- ##
==========================================
- Coverage 88.42% 88.42% -0.01%
==========================================
Files 654 654
Lines 187852 187862 +10
Branches 36134 36136 +2
==========================================
+ Hits 166102 166109 +7
- Misses 14989 15001 +12
+ Partials 6761 6752 -9
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
|
I still consider this a bug fix and not a major change. |
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55296 ✔ Done loading data for nodejs/node/pull/55296 ----------------------------------- PR info ------------------------------------ Title crypto: fix non-multiple of 8 in SubtleCrypto.deriveBits (#55296) Author Filip Skokan <[email protected]> (@panva) Branch panva:non-8-slice -> nodejs:main Labels crypto, needs-ci, webcrypto, web-standards Commits 1 - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits Committers 1 - Filip Skokan <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55296 Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55296 Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits ℹ This PR was created on Sun, 06 Oct 2024 19:20:39 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55296#pullrequestreview-2416995290 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-15T17:44:54Z: https://ci.nodejs.org/job/node-test-pull-request/63558/ - Querying data for job/node-test-pull-request/63558/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11988213766 |
jasnell
pushed a commit
that referenced
this pull request
Nov 23, 2024
PR-URL: #55296 Reviewed-By: James M Snell <[email protected]>
|
Landed in 0116e80 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55296 Reviewed-By: James M Snell <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55296 Reviewed-By: James M Snell <[email protected]>
panva
added
lts-watch-v20.x
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WPT update made me look into this.
From the Node.js docs:
This was never true, instead the implementation returned the closest full byte length.
At the moment the browser implementations do the following
There's no interop on this in the first place and there's a pending decision around disallowing truncation in ECDH/X25519/X448 altogether in a future spec update.
Given that this is in my opinion a semver-majorPRs that contain breaking changes and should be released in the next major version.
change I would rather we only have to do one, i.e. disallow truncation when the spec changes in a major, or fix the implementation with this PR in a major. We've got time to figure out what to do in time for v24.x but i'm opening this to ping @nodejs/crypto and @nodejs/web-standards