-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: set stream prototype to closest transferable superclass #55067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55067 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 652 652
Lines 183912 183926 +14
Branches 35865 35858 -7
=======================================
+ Hits 162272 162290 +18
- Misses 14915 14917 +2
+ Partials 6725 6719 -6
|
RedYetiDev
reviewed
Sep 22, 2024
RedYetiDev
reviewed
Sep 22, 2024
jazelly
force-pushed
the
fix-54603
branch
2 times, most recently
from
September 23, 2024 01:13
6abe0ca
to
feaf4d0
Compare
MattiasBuelens
approved these changes
Sep 23, 2024
RedYetiDev
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Sep 23, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 23, 2024
targos
approved these changes
Sep 23, 2024
Benchmark LGTM
|
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 24, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 24, 2024
Landed in 0e52836 |
🚀 Great! I'll rebase this into the WPT update PR, and it should be ready to review then :-) |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55067 Fixes: #54603 Refs: #50107 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55067 Fixes: nodejs#54603 Refs: nodejs#50107 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Nov 16, 2024
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55067 Fixes: nodejs#54603 Refs: nodejs#50107 Reviewed-By: Mattias Buelens <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-benchmark-ci
PR that need a benchmark CI run.
needs-ci
PRs that need a full CI run.
web streams
web-standards
Issues and PRs related to Web APIs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest WPT test requires this behaviour. The
ReflectConstruct
way did this well, but there was an attempt to reduce theReflectConstruct
overhead breaking this, since it introduced a "closer" superclass underReadable
(orWritable
etc.).Fixes: #54603
Refs: #50107