Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding more tests for strip-types #54929

Merged
merged 1 commit into from
Oct 2, 2024
Merged

test: adding more tests for strip-types #54929

merged 1 commit into from
Oct 2, 2024

Conversation

kevinuehara
Copy link
Contributor

In this MR I'm adding more tests created in this PR, testing generics and Utility Types.
This PR makes part of typescript iniciative on Node.

cc: @RedYetiDev @marco-ippolito @ErickWendel

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests. labels Sep 13, 2024
RedYetiDev
RedYetiDev reviewed Sep 13, 2024
View reviewed changes
test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved
test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 13, 2024
@marco-ippolito
Copy link
Member

Again commits do not point to your github profile or email

@RedYetiDev
Copy link
Member

Again commits do not point to your github profile or email

The commits point to Kevin Uehara <[email protected]>, whereas your github profile's commits point to Gayathri <[email protected]>

@kevinuehara kevinuehara force-pushed the kevinuehara/adding-typescript-tests branch from 0d4dde4 to e1fbc08 Compare September 13, 2024 21:16
@kevinuehara
Copy link
Contributor Author

kevinuehara commented Sep 13, 2024 •
edited
Loading

@marco-ippolito @RedYetiDev I update the author of commits... the ifood account is my work author :)

@RedYetiDev
Copy link
Member

@marco-ippolito how does this fixture compare to the other ones? Just want to make sure they are all similar

@marco-ippolito
Copy link
Member

marco-ippolito commented Sep 19, 2024 •
edited
Loading

To be honest I dont think there is much value in testing TypeScript features such as Unions and Generics, since we rely on swc and swc tests that the output they produce is correct. Im ok with asserting that parameter properties throw in striptypes mode

@kevinuehara
Copy link
Contributor Author

@marco-ippolito @RedYetiDev Do you think we can approve and merge this PR?

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62690/

@RedYetiDev RedYetiDev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2024
@kevinuehara kevinuehara force-pushed the kevinuehara/adding-typescript-tests branch from ccfa065 to f5ef1e0 Compare September 23, 2024 14:39
mhdawson
mhdawson approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 23, 2024 •
edited
Loading

What's the issue you are having?

git reset --soft HEAD~<n> # where <n> represents the number of commits, in this case, 9
git commit

May also work. (See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together)

@kevinuehara
Copy link
Contributor Author

What's the issue you are having?

When I use the git rebase -i HEAD~2 all these commits appear due to the update with main:

image

@RedYetiDev
Copy link
Member

RedYetiDev commented Sep 23, 2024 •
edited
Loading

Oh okay. IIRC what you'll want to do is get the latest commit from main, and run

git reset --hard <commit> # Right now it's c237eabf4c8f1d5ff6dfa95ae30930d6fc959d4e

Caution

This is a dangerous command. It'll remove all uncommitted changes, and revert your local workspace to look identical to <commit> (c237eab)

After this, re-add the changes from this PR. This can be done manually, or via git apply path/to/file.diff with the PR's diff file.

Once this is done, you can git add . and git commit

@kevinuehara kevinuehara force-pushed the kevinuehara/adding-typescript-tests branch from 427b202 to 240c9e9 Compare September 23, 2024 18:00
@kevinuehara
Copy link
Contributor Author

@RedYetiDev I achieved! Thank you so much

@kevinuehara
Copy link
Contributor Author

@RedYetiDev Is there anyone who can validate and merge the PR?

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62855/

@kevinuehara
Copy link
Contributor Author

@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?

@marco-ippolito
Copy link
Member

@RedYetiDev @marco-ippolito I saw that an error was occurring in the tests, but it was not one that I created or changed. Can you help?

Its just flaky tests Ill re run the CI

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62873/

@RedYetiDev

This comment was marked as duplicate.

Sign in to view
@kevinuehara
Copy link
Contributor Author

Thank you @marco-ippolito !!!

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2755551 into nodejs:main Oct 2, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2755551

This was referenced Oct 2, 2024
Closed
Closed
targos pushed a commit that referenced this pull request Oct 4, 2024
@kevinuehara @targos
test: adding more tests for strip-types
2e8d105 
PR-URL: #54929
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@kevinuehara @targos
test: adding more tests for strip-types
ce67e7b 
PR-URL: #54929
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@kevinuehara @louwers
test: adding more tests for strip-types
64898c6 
PR-URL: nodejs#54929
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@kevinuehara @tpoisseau
test: adding more tests for strip-types
40d7f33 
PR-URL: nodejs#54929
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinuehara @nodejs-github-bot @marco-ippolito @RedYetiDev @mhdawson