zlib: use new.target to check for instantiation #54694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
commented
Sep 1, 2024
anonrig
added
the
commit-queue-squash
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54694 +/- ##
==========================================
+ Coverage 87.33% 87.60% +0.27%
==========================================
Files 650 650
Lines 182832 182843 +11
Branches 35067 35384 +317
==========================================
+ Hits 159670 160180 +510
+ Misses 16421 15929 -492
+ Partials 6741 6734 -7
|
anonrig
force-pushed
the
yagiz/use-new-target
branch
from
7c70f41
to
e7449c4
Compare
anonrig
added
the
semver-major
|
@nodejs/tsc this is a semver-major because the removed test is broken. |
RedYetiDev
reviewed
Sep 1, 2024
anonrig
force-pushed
the
yagiz/use-new-target
branch
from
e7449c4
to
1af1c3b
Compare
anonrig
force-pushed
the
yagiz/use-new-target
branch
from
1af1c3b
to
e74e917
Compare
ljharb
reviewed
Sep 2, 2024
| @@ -706,57 +706,64 @@ Zlib.prototype.params = function params(level, strategy, callback) { | |||
| // generic zlib | |||
| // minimal 2-byte header | |||
| function Deflate(opts) { | |||
| if (!(this instanceof Deflate)) | |||
| if (!new.target) { | |||
There was a problem hiding this comment.
Suggested change
| if (!new.target) { | |
| if (new.target !== Deflate) { |
if you also want to normalize subclasses
|
Is this more performant? Would it work with subclasses? |
aduh95
reviewed
Sep 3, 2024
There was a problem hiding this comment.
That seems like something we would want to support, at least using ES6 class syntax
There was a problem hiding this comment.
With the ES6 syntax this test would still pass (except if doing #54694 (comment)).
I guess this change only makes sense if done together with #54676, since this is about detecting when new is used or not.
mcollina
requested changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to @nicolo-ribaudo's comment: #54676 (comment)