Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x] Backport: "module: fix discrepancy between .ts and .js" #54566

Closed
wants to merge 1 commit into from
Closed

[v22.x] Backport: "module: fix discrepancy between .ts and .js" #54566

wants to merge 1 commit into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Aug 26, 2024 •
edited
Loading

As requested in #54461 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Aug 26, 2024
@marco-ippolito marco-ippolito changed the title [v22.x] Backport "module: fix discrepancy between .ts and .js" [v22.x] Backport: "module: fix discrepancy between .ts and .js" Aug 26, 2024
@marco-ippolito
Copy link
Member Author

needs a rebase since v22.x-staging does not build

@RafaelGSS RafaelGSS force-pushed the v22.x-staging branch 2 times, most recently from 625e10a to 5443033 Compare August 30, 2024 18:52
@RafaelGSS RafaelGSS force-pushed the v22.x-staging branch 3 times, most recently from e9a76ae to 6f0cf35 Compare September 1, 2024 01:59
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61854/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61900/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61911/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62239/

@aduh95 aduh95 force-pushed the v22.x-staging branch 2 times, most recently from fec390e to 2b68c30 Compare September 13, 2024 22:27
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62479/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62480/

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62497/

@marco-ippolito marco-ippolito mentioned this pull request Sep 17, 2024
Merged
@marco-ippolito
module: fix discrepancy between .ts and .js
8c6a2c1 
PR-URL: nodejs#54461
Fixes: nodejs#54457
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62506/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62513/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62517/

marco-ippolito added a commit that referenced this pull request Sep 18, 2024
@marco-ippolito
module: fix discrepancy between .ts and .js
67ecb10 
PR-URL: #54461
Backport-PR-URL: #54566
Fixes: #54457
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@marco-ippolito
Copy link
Member Author

Landed in 67ecb10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-ippolito @nodejs-github-bot @ShogunPanda @Qard