Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update amaro to 0.1.7 #54473

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of amaro to 0.1.7.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support labels Aug 21, 2024
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing swc license 🫤

@kdy1
Copy link
Member

kdy1 commented Aug 21, 2024

Is it a problem of the SWC package?

@marco-ippolito marco-ippolito dismissed their stale review August 21, 2024 07:20

NEVER MIND we already added that in a previous release

@marco-ippolito
Copy link
Member

Is it a problem of the SWC package?

nono we already added and I forgot 😆 all good

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (821ffab) to head (05f328e).
Report is 334 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54473      +/-   ##
==========================================
- Coverage   87.31%   87.29%   -0.03%     
==========================================
  Files         648      648              
  Lines      182365   182365              
  Branches    34988    34977      -11     
==========================================
- Hits       159236   159194      -42     
- Misses      16393    16446      +53     
+ Partials     6736     6725      -11     

see 29 files with indirect coverage changes

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit d787144 into main Aug 23, 2024
71 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in d787144

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-amaro branch August 23, 2024 07:23
RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
PR-URL: #54473
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54473
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants